Unverified Commit 9e07f8bf authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Mark Brown
Browse files

ASoC: cs42l43: Fix missing error code in cs42l43_codec_probe() 



When clk_get_optional() fails, the error handling code does a 'goto
err_pm' with ret = 0, which is resturning success on a failure path.

Fix this by assigning the PTR_ERR(priv-mclk) to ret variable.

Fixes: fc918cbe ("ASoC: cs42l43: Add support for the cs42l43")
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230829073635.1877367-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e041b850

sound/soc/codecs/cs42l43.c

+2 −1
Original line number Diff line number Diff line
@@ -2205,7 +2205,8 @@ static int cs42l43_codec_probe(struct platform_device *pdev) 
	// Don't use devm as we need to get against the MFD device

	priv->mclk = clk_get_optional(cs42l43->dev, "mclk");

	if (IS_ERR(priv->mclk)) {

		dev_err_probe(priv->dev, PTR_ERR(priv->mclk), "Failed to get mclk\n");

		ret = PTR_ERR(priv->mclk);

		dev_err_probe(priv->dev, ret, "Failed to get mclk\n");

		goto err_pm;

	}