Commit 9dedc915 authored by zhang songyi's avatar zhang songyi Committed by Dmitry Torokhov
Browse files

Input: synaptics-rmi4 - convert to use sysfs_emit() APIs 



Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the value
to be returned to user space.

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarzhang songyi <zhang.songyi@zte.com.cn>
Link: https://lore.kernel.org/r/20220927070936.258300-1-zhang.songyi@zte.com.cn


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 2b7672b0

drivers/input/rmi4/rmi_f34.c

+8 −8
Original line number Diff line number Diff line
@@ -321,11 +321,11 @@ static ssize_t rmi_driver_bootloader_id_show(struct device *dev, 
		f34 = dev_get_drvdata(&fn->dev);



		if (f34->bl_version == 5)

			return scnprintf(buf, PAGE_SIZE, "%c%c\n",

			return sysfs_emit(buf, "%c%c\n",

					  f34->bootloader_id[0],

					  f34->bootloader_id[1]);

		else

			return scnprintf(buf, PAGE_SIZE, "V%d.%d\n",

			return sysfs_emit(buf, "V%d.%d\n",

					  f34->bootloader_id[1],

					  f34->bootloader_id[0]);

	}
@@ -346,7 +346,7 @@ static ssize_t rmi_driver_configuration_id_show(struct device *dev, 
	if (fn) {

		f34 = dev_get_drvdata(&fn->dev);



		return scnprintf(buf, PAGE_SIZE, "%s\n", f34->configuration_id);

		return sysfs_emit(buf, "%s\n", f34->configuration_id);

	}



	return 0;
@@ -499,7 +499,7 @@ static ssize_t rmi_driver_update_fw_status_show(struct device *dev, 
	if (data->f34_container)

		update_status = rmi_f34_status(data->f34_container);



	return scnprintf(buf, PAGE_SIZE, "%d\n", update_status);

	return sysfs_emit(buf, "%d\n", update_status);

}



static DEVICE_ATTR(update_fw_status, 0444,