Commit 9deb48b5 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by David S. Miller
Browse files

bcmgenet: add WOL IRQ check 



The driver neglects to check the result of platform_get_irq_optional()'s
call and blithely passes the negative error codes to devm_request_irq()
(which takes *unsigned* IRQ #), causing it to fail with -EINVAL.
Stop calling devm_request_irq() with the invalid IRQ #s.

Fixes: 8562056f ("net: bcmgenet: request Wake-on-LAN interrupt")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fb80445c

drivers/net/ethernet/broadcom/genet/bcmgenet.c

+6 −4
Original line number Diff line number Diff line
@@ -4020,10 +4020,12 @@ static int bcmgenet_probe(struct platform_device *pdev) 


	/* Request the WOL interrupt and advertise suspend if available */

	priv->wol_irq_disabled = true;

	err = devm_request_irq(&pdev->dev, priv->wol_irq, bcmgenet_wol_isr, 0,

			       dev->name, priv);

	if (priv->wol_irq > 0) {

		err = devm_request_irq(&pdev->dev, priv->wol_irq,

				       bcmgenet_wol_isr, 0, dev->name, priv);

		if (!err)

			device_set_wakeup_capable(&pdev->dev, 1);

	}



	/* Set the needed headroom to account for any possible

	 * features enabling/disabling at runtime