Commit 9deb1e9f authored by Daniil Tatianin's avatar Daniil Tatianin Committed by David S. Miller
Browse files

net/ethtool/ioctl: return -EOPNOTSUPP if we have no phy stats 



It's not very useful to copy back an empty ethtool_stats struct and
return 0 if we didn't actually have any stats. This also allows for
further simplification of this function in the future commits.

Signed-off-by: default avatarDaniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8ac718cc

net/ethtool/ioctl.c

+2 −1
Original line number Diff line number Diff line
@@ -2099,7 +2099,8 @@ static int ethtool_get_phy_stats(struct net_device *dev, void __user *useraddr) 
		return n_stats;

	if (n_stats > S32_MAX / sizeof(u64))

		return -ENOMEM;

	WARN_ON_ONCE(!n_stats);

	if (WARN_ON_ONCE(!n_stats))

		return -EOPNOTSUPP;



	if (copy_from_user(&stats, useraddr, sizeof(stats)))

		return -EFAULT;