Commit 9ddcd920 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Vinod Koul
Browse files

phy: qcom-qmp-pcie: Fix high latency with 4x2 PHY when ASPM is enabled 



The PCIe QMP 4x2 RC PHY generates high latency when ASPM is enabled. This
seem to be fixed by clearing the QPHY_V5_20_PCS_PCIE_PRESET_P10_POST
register of the pcs_misc register space.

Fixes: 2c91bf6b ("phy: qcom-qmp: Add SM8450 PCIe1 PHY support")
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20221102081835.41892-1-manivannan.sadhasivam@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 2584068a

drivers/phy/qualcomm/phy-qcom-qmp-pcie.c

+1 −0
Original line number Diff line number Diff line
@@ -1430,6 +1430,7 @@ static const struct qmp_phy_init_tbl sm8450_qmp_gen4x2_pcie_pcs_misc_tbl[] = { 
static const struct qmp_phy_init_tbl sm8450_qmp_gen4x2_pcie_rc_pcs_misc_tbl[] = {

	QMP_PHY_INIT_CFG(QPHY_V5_20_PCS_PCIE_ENDPOINT_REFCLK_DRIVE, 0xc1),

	QMP_PHY_INIT_CFG(QPHY_V5_20_PCS_PCIE_OSC_DTCT_ACTIONS, 0x00),

	QMP_PHY_INIT_CFG(QPHY_V5_20_PCS_PCIE_PRESET_P10_POST, 0x00),

};



static const struct qmp_phy_init_tbl sm8450_qmp_gen4x2_pcie_ep_serdes_tbl[] = {

drivers/phy/qualcomm/phy-qcom-qmp-pcs-pcie-v5_20.h

+1 −0
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ 
#define QPHY_V5_20_PCS_PCIE_OSC_DTCT_MODE2_CONFIG5	0x084

#define QPHY_V5_20_PCS_PCIE_OSC_DTCT_ACTIONS		0x090

#define QPHY_V5_20_PCS_PCIE_EQ_CONFIG1			0x0a0

#define QPHY_V5_20_PCS_PCIE_PRESET_P10_POST		0x0e0

#define QPHY_V5_20_PCS_PCIE_G4_EQ_CONFIG5		0x108

#define QPHY_V5_20_PCS_PCIE_G4_PRE_GAIN			0x15c

#define QPHY_V5_20_PCS_PCIE_RX_MARGINING_CONFIG3	0x184