Commit 9d6794fe authored by Ira Weiny's avatar Ira Weiny Committed by Dan Williams
Browse files

driver-core: Introduce BIN_ATTR_ADMIN_{RO,RW} 



Many binary attributes need to limit access to CAP_SYS_ADMIN only; ie
many binary attributes specify is_visible with 0400 or 0600.

Make setting the permissions of such attributes more explicit by
defining BIN_ATTR_ADMIN_{RO,RW}.

Cc: Bjorn Helgaas <bhelgaas@google.com>
Suggested-by: default avatarDan Williams <dan.j.williams@intel.com>
Suggested-by: default avatarKrzysztof Wilczyński <kw@linux.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Link: https://lore.kernel.org/r/20220719205249.566684-6-ira.weiny@intel.com


Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 3eddcc93

include/linux/sysfs.h

+16 −0
Original line number Diff line number Diff line
@@ -235,6 +235,22 @@ struct bin_attribute bin_attr_##_name = __BIN_ATTR_WO(_name, _size) 
#define BIN_ATTR_RW(_name, _size)					\

struct bin_attribute bin_attr_##_name = __BIN_ATTR_RW(_name, _size)





#define __BIN_ATTR_ADMIN_RO(_name, _size) {					\

	.attr	= { .name = __stringify(_name), .mode = 0400 },		\

	.read	= _name##_read,						\

	.size	= _size,						\

}



#define __BIN_ATTR_ADMIN_RW(_name, _size)					\

	__BIN_ATTR(_name, 0600, _name##_read, _name##_write, _size)



#define BIN_ATTR_ADMIN_RO(_name, _size)					\

struct bin_attribute bin_attr_##_name = __BIN_ATTR_ADMIN_RO(_name, _size)



#define BIN_ATTR_ADMIN_RW(_name, _size)					\

struct bin_attribute bin_attr_##_name = __BIN_ATTR_ADMIN_RW(_name, _size)



struct sysfs_ops {

	ssize_t	(*show)(struct kobject *, struct attribute *, char *);

	ssize_t	(*store)(struct kobject *, struct attribute *, const char *, size_t);