Commit 9d6366e7 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Daniel Vetter
Browse files

drm: fb_helper: improve CONFIG_FB dependency 



My previous patch correctly addressed the possible link failure, but as
Jani points out, the dependency is now stricter than it needs to be.

Change it again, to allow DRM_FBDEV_EMULATION to be used when
DRM_KMS_HELPER and FB are both loadable modules and DRM is linked into
the kernel.

As a side-effect, the option is now only visible when at least one DRM
driver makes use of DRM_KMS_HELPER. This is better, because the option
has no effect otherwise.

Fixes: 606b1028 ("drm: fb_helper: fix CONFIG_FB dependency")
Suggested-by: default avatarAcked-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20211029120307.1407047-1-arnd@kernel.org
parent e0e6d1ea

drivers/gpu/drm/Kconfig

+2 −3
Original line number Diff line number Diff line
@@ -117,9 +117,8 @@ config DRM_DEBUG_MODESET_LOCK 


config DRM_FBDEV_EMULATION

	bool "Enable legacy fbdev support for your modesetting driver"

	depends on DRM

	depends on FB=y || FB=DRM

	select DRM_KMS_HELPER

	depends on DRM_KMS_HELPER

	depends on FB=y || FB=DRM_KMS_HELPER

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT