Commit 9d5b9ad9 authored by Mukesh Ojha's avatar Mukesh Ojha Committed by Bjorn Andersson
Browse files

remoteproc: qcom: replace kstrdup with kstrndup 



Since, there is no guarantee that region.name will be 0-terminated
from the firmware side, replace kstrdup with kstrndup.

Suggested-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: default avatarMukesh Ojha <quic_mojha@quicinc.com>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/1676383691-29738-1-git-send-email-quic_mojha@quicinc.com
parent 64058718

drivers/remoteproc/qcom_common.c

+1 −1
Original line number Diff line number Diff line
@@ -124,7 +124,7 @@ static int qcom_add_minidump_segments(struct rproc *rproc, struct minidump_subsy 
	for (i = 0; i < seg_cnt; i++) {

		memcpy_fromio(&region, ptr + i, sizeof(region));

		if (region.valid == MD_REGION_VALID) {

			name = kstrdup(region.name, GFP_KERNEL);

			name = kstrndup(region.name, MAX_REGION_NAME_LENGTH - 1, GFP_KERNEL);

			if (!name) {

				iounmap(ptr);

				return -ENOMEM;