Commit 9d549836 authored by Maurizio Lombardi's avatar Maurizio Lombardi Committed by Yang Yingliang
Browse files

scsi: target: core: Fix warning on realtime kernels 

stable inclusion
from linux-4.19.196
commit 8fa2bb8837ea92f725e63ec38935195bc0266668

--------------------------------

[ Upstream commit 515da6f4 ]

On realtime kernels, spin_lock_irq*(spinlock_t) do not disable the
interrupts, a call to irqs_disabled() will return false thus firing a
warning in __transport_wait_for_tasks().

Remove the warning and also replace assert_spin_locked() with
lockdep_assert_held()

Link: https://lore.kernel.org/r/20210531121326.3649-1-mlombard@redhat.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMaurizio Lombardi <mlombard@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
parent bb52554b

drivers/target/target_core_transport.c

+1 −3
Original line number Diff line number Diff line
@@ -2982,9 +2982,7 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, 
	__releases(&cmd->t_state_lock)

	__acquires(&cmd->t_state_lock)

{



	assert_spin_locked(&cmd->t_state_lock);

	WARN_ON_ONCE(!irqs_disabled());

	lockdep_assert_held(&cmd->t_state_lock);



	if (fabric_stop)

		cmd->transport_state |= CMD_T_FABRIC_STOP;