Commit 9ccfc23a authored by Steve French's avatar Steve French
Browse files

smb3: don't set rc when used and unneeded in query_info_compound 



rc is not checked so should not be set coming back from open_cached_dir
(the cfid pointer is checked instead to see if open_cached_dir failed)

Addresses-Coverity: 1518021 ("Code maintainability issues  (UNUSED_VALUE)")
Reviewed-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent bbdf6cf5

fs/cifs/smb2ops.c

+1 −1
Original line number Diff line number Diff line
@@ -2700,7 +2700,7 @@ smb2_query_info_compound(const unsigned int xid, struct cifs_tcon *tcon, 
	memset(rsp_iov, 0, sizeof(rsp_iov));



	if (!strcmp(path, ""))

		rc = open_cached_dir(xid, tcon, path, cifs_sb, &cfid);

		open_cached_dir(xid, tcon, path, cifs_sb, &cfid); /* cfid null if open dir failed */



	memset(&open_iov, 0, sizeof(open_iov));

	rqst[0].rq_iov = open_iov;