Commit 9cb9dadb authored by Shannon Nelson's avatar Shannon Nelson Committed by Jakub Kicinski
Browse files

ionic: clear broken state on generation change 



There is a case found in heavy testing where a link flap happens just
before a firmware Recovery event and the driver gets stuck in the
BROKEN state.  This comes from the driver getting interrupted by a FW
generation change when coming back up from the link flap, and the call
to ionic_start_queues() in ionic_link_status_check() fails.  This can be
addressed by having the fw_up code clear the BROKEN bit if seen, rather
than waiting for a user to manually force the interface down and then
back up.

Fixes: 9e8eaf84 ("ionic: stop watchdog when in broken state")
Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b0f571ec

drivers/net/ethernet/pensando/ionic/ionic_lif.c

+3 −0
Original line number Diff line number Diff line
@@ -2963,6 +2963,9 @@ static void ionic_lif_handle_fw_up(struct ionic_lif *lif) 


	mutex_lock(&lif->queue_lock);



	if (test_and_clear_bit(IONIC_LIF_F_BROKEN, lif->state))

		dev_info(ionic->dev, "FW Up: clearing broken state\n");



	err = ionic_qcqs_alloc(lif);

	if (err)

		goto err_unlock;