Commit 9c9d7099 authored by Paul Cercueil's avatar Paul Cercueil Committed by Miquel Raynal
Browse files

mtd: rawnand: davinci: Avoid duplicated page read 



The function nand_davinci_read_page_hwecc_oob_first() first reads the
OOB data, extracts the ECC information, programs the ECC hardware before
reading the actual data in a loop.

Right after the OOB data was read, it called nand_read_page_op() to
reset the read cursor to the beginning of the page. This caused the
first page to be read twice: in that call, and later in the loop.

Address that issue by changing the call to nand_read_page_op() to
nand_change_read_column_op(), which will only reset the read cursor.

Cc: <stable@vger.kernel.org> # v5.2
Fixes: a0ac778e ("mtd: rawnand: ingenic: Add support for the JZ4740")
Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20211016132228.40254-2-paul@crapouillou.net
parent 71e89591

drivers/mtd/nand/raw/davinci_nand.c

+2 −1
Original line number Diff line number Diff line
@@ -401,7 +401,8 @@ static int nand_davinci_read_page_hwecc_oob_first(struct nand_chip *chip, 
	if (ret)

		return ret;



	ret = nand_read_page_op(chip, page, 0, NULL, 0);

	/* Move read cursor to start of page */

	ret = nand_change_read_column_op(chip, 0, NULL, 0, false);

	if (ret)

		return ret;