Commit 9c9d5e99 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: crc: Propagate errors in .get_state() to the caller 



.get_state() can return an error indication. Make use of it to propagate
failing hardware accesses.

Acked-by: default avatarConor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20221130152148.2769768-6-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent fea768cf

drivers/pwm/pwm-crc.c

+2 −2
Original line number Diff line number Diff line
@@ -132,13 +132,13 @@ static int crc_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, 
	error = regmap_read(crc_pwm->regmap, PWM0_CLK_DIV, &clk_div_reg);

	if (error) {

		dev_err(dev, "Error reading PWM0_CLK_DIV %d\n", error);

		return 0;

		return error;

	}



	error = regmap_read(crc_pwm->regmap, PWM0_DUTY_CYCLE, &duty_cycle_reg);

	if (error) {

		dev_err(dev, "Error reading PWM0_DUTY_CYCLE %d\n", error);

		return 0;

		return error;

	}



	clk_div = (clk_div_reg & ~PWM_OUTPUT_ENABLE) + 1;