Commit 9c9cb23e authored by Xin Xiong's avatar Xin Xiong Committed by Steffen Klassert
Browse files

xfrm: fix refcount leak in __xfrm_policy_check() 



The issue happens on an error path in __xfrm_policy_check(). When the
fetching process of the object `pols[1]` fails, the function simply
returns 0, forgetting to decrement the reference count of `pols[0]`,
which is incremented earlier by either xfrm_sk_policy_lookup() or
xfrm_policy_lookup(). This may result in memory leaks.

Fix it by decreasing the reference count of `pols[0]` in that path.

Fixes: 134b0fc5 ("IPsec: propagate security module errors up from flow_cache_lookup")
Signed-off-by: default avatarXin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: default avatarXin Tan <tanxin.ctf@gmail.com>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent 9b134b16

net/xfrm/xfrm_policy.c

+1 −0
Original line number Diff line number Diff line
@@ -3599,6 +3599,7 @@ int __xfrm_policy_check(struct sock *sk, int dir, struct sk_buff *skb, 
		if (pols[1]) {

			if (IS_ERR(pols[1])) {

				XFRM_INC_STATS(net, LINUX_MIB_XFRMINPOLERROR);

				xfrm_pol_put(pols[0]);

				return 0;

			}

			pols[1]->curlft.use_time = ktime_get_real_seconds();