Commit 9c93f8f4 authored by Sanket Goswami's avatar Sanket Goswami Committed by Hans de Goede
Browse files

platform/x86: amd-pmc: Send command to dump data after clearing OS_HINT 



It was reported that the resume stats received from the firmware are
always zero. This happens because the SMU expects the driver to send the
command to dump the log data after clearing the OS_HINT.

Adjust the order of the commands sent to SMU.

Signed-off-by: default avatarShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: default avatarSanket Goswami <Sanket.Goswami@amd.com>
Link: https://lore.kernel.org/r/20210921115910.19401-1-Sanket.Goswami@amd.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 40635cd3

drivers/platform/x86/amd-pmc.c

+3 −3
Original line number Diff line number Diff line
@@ -436,14 +436,14 @@ static int __maybe_unused amd_pmc_resume(struct device *dev) 
	int rc;

	u8 msg;



	/* Let SMU know that we are looking for stats */

	amd_pmc_send_cmd(pdev, 0, NULL, SMU_MSG_LOG_DUMP_DATA, 0);



	msg = amd_pmc_get_os_hint(pdev);

	rc = amd_pmc_send_cmd(pdev, 0, NULL, msg, 0);

	if (rc)

		dev_err(pdev->dev, "resume failed\n");



	/* Let SMU know that we are looking for stats */

	amd_pmc_send_cmd(pdev, 0, NULL, SMU_MSG_LOG_DUMP_DATA, 0);



	/* Dump the IdleMask to see the blockers */

	amd_pmc_idlemask_read(pdev, dev, NULL);