Commit 9c8bbfac authored Apr 29, 2022 by Baolin Wang Committed by Andrew Morton Apr 29, 2022

mm: hugetlb: add missing cache flushing in hugetlb_unshare_all_pmds()

Missed calling flush_cache_range() before removing the sharing PMD
entrires, otherwise data consistence issue may be occurred on some
architectures whose caches are strict and require a virtual>physical
translation to exist for a virtual address. Thus add it.

Now no architectures enabling PMD sharing will be affected, since they do
not have a VIVT cache. That means this issue can not be happened in
practice so far.

Link: https://lkml.kernel.org/r/47441086affcabb6ecbe403173e9283b0d904b38.1650956489.git.baolin.wang@linux.alibaba.com
Link: https://lkml.kernel.org/r/419b0e777c9e6d1454dcd906e0f5b752a736d335.1650781755.git.baolin.wang@linux.alibaba.com

Fixes: 6dfeaff9 ("hugetlb/userfaultfd: unshare all pmds for hugetlbfs when register wp")
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

parent 25fa414a

mm/hugetlb.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -6886,6 +6886,7 @@ void hugetlb_unshare_all_pmds(struct vm_area_struct *vma)
	if (start >= end)		if (start >= end)
	return;		return;

			flush_cache_range(vma, start, end);
	/*		/*
	* No need to call adjust_range_if_pmd_sharing_possible(), because		* No need to call adjust_range_if_pmd_sharing_possible(), because
	* we have already done the PUD_SIZE alignment.		* we have already done the PUD_SIZE alignment.