Commit 9c807965 authored by Daniil Tatianin's avatar Daniil Tatianin Committed by David S. Miller
Browse files

drivers/net/bonding/bond_3ad: return when there's no aggregator 



Otherwise we would dereference a NULL aggregator pointer when calling
__set_agg_ports_ready on the line below.

Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarDaniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d57609fa

drivers/net/bonding/bond_3ad.c

+1 −0
Original line number Diff line number Diff line
@@ -1549,6 +1549,7 @@ static void ad_port_selection_logic(struct port *port, bool *update_slave_arr) 
			slave_err(bond->dev, port->slave->dev,

				  "Port %d did not find a suitable aggregator\n",

				  port->actor_port_number);

			return;

		}

	}

	/* if all aggregator's ports are READY_N == TRUE, set ready=TRUE