Commit 9c7c4bc9 authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe
Browse files

ublk: remove check IO_URING_F_SQE128 in ublk_ch_uring_cmd 



sizeof(struct ublksrv_io_cmd) is 16bytes, which can be held in 64byte SQE,
so not necessary to check IO_URING_F_SQE128.

With this change, we get chance to save half SQ ring memory.

Fixed: 71f28f31 ("ublk_drv: add io_uring based userspace block driver")
Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20230220041413.1524335-1-ming.lei@redhat.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9e0c7efa

drivers/block/ublk_drv.c

+0 −3
Original line number Diff line number Diff line
@@ -1271,9 +1271,6 @@ static int ublk_ch_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags) 
			__func__, cmd->cmd_op, ub_cmd->q_id, tag,

			ub_cmd->result);



	if (!(issue_flags & IO_URING_F_SQE128))

		goto out;



	if (ub_cmd->q_id >= ub->dev_info.nr_hw_queues)

		goto out;