Commit 9c73576c authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers 



The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by kzalloc(). So do not
set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v2:
	* fix commit message (Miguel)

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Cc: Andy Walls <awalls@md.metrocast.net>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-12-tzimmermann@suse.de
parent 8bf3ea7d

drivers/media/pci/ivtv/ivtvfb.c

+0 −1
Original line number Diff line number Diff line
@@ -1048,7 +1048,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv) 
	/* Generate valid fb_info */



	oi->ivtvfb_info.node = -1;

	oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT;

	oi->ivtvfb_info.par = itv;

	oi->ivtvfb_info.var = oi->ivtvfb_defined;

	oi->ivtvfb_info.fix = oi->ivtvfb_fix;

drivers/media/test-drivers/vivid/vivid-osd.c

+0 −1
Original line number Diff line number Diff line
@@ -310,7 +310,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev) 
	/* Generate valid fb_info */



	dev->fb_info.node = -1;

	dev->fb_info.flags = FBINFO_FLAG_DEFAULT;

	dev->fb_info.par = dev;

	dev->fb_info.var = dev->fb_defined;

	dev->fb_info.fix = dev->fb_fix;