Commit 9c7067ed authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by sanglipeng
Browse files

kernel/fail_function: fix memory leak with using debugfs_lookup() 

stable inclusion
from stable-v5.10.173
commit dd9981a11d74ff2eb253bb5c459876f8bd3c6c36
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7X0QU

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=dd9981a11d74ff2eb253bb5c459876f8bd3c6c36



--------------------------------

[ Upstream commit 2bb3669f ]

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20230202151633.2310897-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent dc420938

kernel/fail_function.c

+1 −4
Original line number Diff line number Diff line
@@ -163,10 +163,7 @@ static void fei_debugfs_add_attr(struct fei_attr *attr) 


static void fei_debugfs_remove_attr(struct fei_attr *attr)

{

	struct dentry *dir;



	dir = debugfs_lookup(attr->kp.symbol_name, fei_debugfs_dir);

	debugfs_remove_recursive(dir);

	debugfs_lookup_and_remove(attr->kp.symbol_name, fei_debugfs_dir);

}



static int fei_kprobe_handler(struct kprobe *kp, struct pt_regs *regs)