Commit 9c5de246 authored by Casper Andersson's avatar Casper Andersson Committed by Jakub Kicinski
Browse files

net: sparx5: mdb add/del handle non-sparx5 devices 



When adding/deleting mdb entries on other net_devices, eg., tap
interfaces, it should not crash.

Fixes: 3bacfccd ("net: sparx5: Add mdb handlers")
Signed-off-by: default avatarCasper Andersson <casper.casan@gmail.com>
Reviewed-by: default avatarSteen Hegelund <Steen.Hegelund@microchip.com>
Link: https://lore.kernel.org/r/20220630122226.316812-1-casper.casan@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0a18d802

drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c

+6 −0
Original line number Diff line number Diff line
@@ -396,6 +396,9 @@ static int sparx5_handle_port_mdb_add(struct net_device *dev, 
	u32 mact_entry;

	int res, err;



	if (!sparx5_netdevice_check(dev))

		return -EOPNOTSUPP;



	if (netif_is_bridge_master(v->obj.orig_dev)) {

		sparx5_mact_learn(spx5, PGID_CPU, v->addr, v->vid);

		return 0;
@@ -466,6 +469,9 @@ static int sparx5_handle_port_mdb_del(struct net_device *dev, 
	u32 mact_entry, res, pgid_entry[3];

	int err;



	if (!sparx5_netdevice_check(dev))

		return -EOPNOTSUPP;



	if (netif_is_bridge_master(v->obj.orig_dev)) {

		sparx5_mact_forget(spx5, v->addr, v->vid);

		return 0;