Commit 9c28ca4f authored Mar 08, 2017 by Nicholas Bellinger

target: Drop pointless tfo->check_stop_free check



All in-tree fabric drivers provide a tfo->check_stop_free(),
so there is no need to do the extra check within existing
transport_cmd_check_stop_to_fabric() code.

Just to be sure, add a check in target_fabric_tf_ops_check()
to notify any out-of-tree drivers that might be missing it.

Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 13603685

drivers/target/target_core_configfs.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -421,6 +421,10 @@ static int target_fabric_tf_ops_check(const struct target_core_fabric_ops *tfo)
		pr_err("Missing tfo->aborted_task()\n");
		return -EINVAL;
		}
		if (!tfo->check_stop_free) {
		pr_err("Missing tfo->check_stop_free()\n");
		return -EINVAL;
		}
		/*
		* We at least require tfo->fabric_make_wwn(), tfo->fabric_drop_wwn()
		* tfo->fabric_make_tpg() and tfo->fabric_drop_tpg() in

drivers/target/target_core_transport.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -636,8 +636,7 @@ static int transport_cmd_check_stop_to_fabric(struct se_cmd *cmd)
		* Fabric modules are expected to return '1' here if the se_cmd being
		* passed is released at this point, or zero if not being released.
		*/
		return cmd->se_tfo->check_stop_free ? cmd->se_tfo->check_stop_free(cmd)
		: 0;
		return cmd->se_tfo->check_stop_free(cmd);
		}

		static void transport_lun_remove_cmd(struct se_cmd *cmd)