Unverified Commit 9c2611b2 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: amd: Do not set ipc_pcm_params ops as it is optional 



The ipc_pcm_params() ops implementation for AMD is a NOP and since the
callback is marked now as optional, it can be dropped along with the
empty function.

Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Reviewed-by: default avatarDaniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220304205733.62233-4-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent edca0623

sound/soc/sof/amd/acp-ipc.c

+0 −8
Original line number Diff line number Diff line
@@ -170,14 +170,6 @@ int acp_sof_ipc_msg_data(struct snd_sof_dev *sdev, struct snd_pcm_substream *sub 
}

EXPORT_SYMBOL_NS(acp_sof_ipc_msg_data, SND_SOC_SOF_AMD_COMMON);



int acp_sof_ipc_pcm_params(struct snd_sof_dev *sdev, struct snd_pcm_substream *substream,

			   const struct sof_ipc_pcm_params_reply *reply)

{

	/* TODO: Implement stream hw params to validate stream offset */

	return 0;

}

EXPORT_SYMBOL_NS(acp_sof_ipc_pcm_params, SND_SOC_SOF_AMD_COMMON);



int acp_sof_ipc_get_mailbox_offset(struct snd_sof_dev *sdev)

{

	return ACP_SCRATCH_MEMORY_ADDRESS;

sound/soc/sof/amd/acp.h

+0 −2
Original line number Diff line number Diff line
@@ -185,8 +185,6 @@ int acp_sof_ipc_send_msg(struct snd_sof_dev *sdev, 
			 struct snd_sof_ipc_msg *msg);

int acp_sof_ipc_get_mailbox_offset(struct snd_sof_dev *sdev);

int acp_sof_ipc_get_window_offset(struct snd_sof_dev *sdev, u32 id);

int acp_sof_ipc_pcm_params(struct snd_sof_dev *sdev, struct snd_pcm_substream *substream,

			   const struct sof_ipc_pcm_params_reply *reply);

void acp_mailbox_write(struct snd_sof_dev *sdev, u32 offset, void *message, size_t bytes);

void acp_mailbox_read(struct snd_sof_dev *sdev, u32 offset, void *message, size_t bytes);

sound/soc/sof/amd/renoir.c

+0 −1
Original line number Diff line number Diff line
@@ -150,7 +150,6 @@ const struct snd_sof_dsp_ops sof_renoir_ops = { 
	/*IPC */

	.send_msg		= acp_sof_ipc_send_msg,

	.ipc_msg_data		= acp_sof_ipc_msg_data,

	.ipc_pcm_params		= acp_sof_ipc_pcm_params,

	.get_mailbox_offset	= acp_sof_ipc_get_mailbox_offset,

	.irq_thread		= acp_sof_ipc_irq_thread,

	.fw_ready		= sof_fw_ready,