Commit 9c230382 authored by John Garry's avatar John Garry Committed by Martin K. Petersen
Browse files

scsi: scsi_debug: Drop scsi_debug_host_reset() device NULL pointer check 



The check for device pointer for the SCSI command is unnecessary, so drop
it.

The only caller is scsi_try_host_reset() -> eh_host_reset_handler(), and
there that pointer cannot be NULL.

Indeed, there is already code later in the same function which does not
check the device pointer for the SCSI command.

Signed-off-by: default avatarJohn Garry <john.g.garry@oracle.com>
Acked-by: default avatarDouglas Gilbert <dgilbert@interlog.com>
Link: https://lore.kernel.org/r/20230313093114.1498305-8-john.g.garry@oracle.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 519bfc14

drivers/scsi/scsi_debug.c

+1 −1
Original line number Diff line number Diff line
@@ -5440,7 +5440,7 @@ static int scsi_debug_host_reset(struct scsi_cmnd *SCpnt) 
	int k = 0;



	++num_host_resets;

	if ((SCpnt->device) && (SDEBUG_OPT_ALL_NOISE & sdebug_opts))

	if (SDEBUG_OPT_ALL_NOISE & sdebug_opts)

		sdev_printk(KERN_INFO, SCpnt->device, "%s\n", __func__);

	spin_lock(&sdebug_host_list_lock);

	list_for_each_entry(sdbg_host, &sdebug_host_list, host_list) {