Commit 9c1eaa27 authored by Zhang Changzhong's avatar Zhang Changzhong Committed by David S. Miller
Browse files

net: lantiq_etop: don't free skb when returning NETDEV_TX_BUSY 



The ndo_start_xmit() method must not free skb when returning
NETDEV_TX_BUSY, since caller is going to requeue freed skb.

Fixes: 504d4721 ("MIPS: Lantiq: Add ethernet driver")
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d266935a

drivers/net/ethernet/lantiq_etop.c

+0 −1
Original line number Diff line number Diff line
@@ -485,7 +485,6 @@ ltq_etop_tx(struct sk_buff *skb, struct net_device *dev) 
	len = skb->len < ETH_ZLEN ? ETH_ZLEN : skb->len;



	if ((desc->ctl & (LTQ_DMA_OWN | LTQ_DMA_C)) || ch->skb[ch->dma.desc]) {

		dev_kfree_skb_any(skb);

		netdev_err(dev, "tx ring full\n");

		netif_tx_stop_queue(txq);

		return NETDEV_TX_BUSY;