Commit 9c15db83 authored by Kumar Kartikeya Dwivedi's avatar Kumar Kartikeya Dwivedi Committed by Greg Kroah-Hartman
Browse files

staging: sm750fb: Switch from strlcpy to strscpy 



strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value). strscpy is relatively better as it
also avoids scanning the whole source string.

This silences the related checkpatch warnings from:
5dbdb2d8 ("checkpatch: prefer strscpy to strlcpy")

Signed-off-by: default avatarKumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20210131172838.146706-13-memxor@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f64e4ab3

drivers/staging/sm750fb/sm750.c

+1 −1
Original line number Diff line number Diff line
@@ -814,7 +814,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) 
	fix->ywrapstep = crtc->ywrapstep;

	fix->accel = FB_ACCEL_SMI;



	strlcpy(fix->id, fixId[index], sizeof(fix->id));

	strscpy(fix->id, fixId[index], sizeof(fix->id));



	fix->smem_start = crtc->oScreen + sm750_dev->vidmem_start;

	pr_info("fix->smem_start = %lx\n", fix->smem_start);