Commit 9bf61b8c authored by Gal Pressman's avatar Gal Pressman Committed by Jason Gunthorpe
Browse files

RDMA/efa: Remove unused 'select' field from get/set feature command descriptor 

The 'select' field in the get/set feature admin command is unimplemented,
unused and misleading, remove it.  The command always refers to the
current values.

Link: https://lore.kernel.org/r/20210126120702.9807-5-galpress@amazon.com


Reviewed-by: default avatarFiras JahJah <firasj@amazon.com>
Reviewed-by: default avatarYossi Leybovich <sleybo@amazon.com>
Signed-off-by: default avatarGal Pressman <galpress@amazon.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 631b6189

drivers/infiniband/hw/efa/efa_admin_cmds_defs.h

+2 −9
Original line number Diff line number Diff line
@@ -563,12 +563,8 @@ struct efa_admin_acq_get_stats_resp { 
};



struct efa_admin_get_set_feature_common_desc {

	/*

	 * 1:0 : select - 0x1 - current value; 0x3 - default

	 *    value

	 * 7:3 : reserved3 - MBZ

	 */

	u8 flags;

	/* MBZ */

	u8 reserved0;



	/* as appears in efa_admin_aq_feature_id */

	u8 feature_id;
@@ -909,9 +905,6 @@ struct efa_admin_host_info { 
#define EFA_ADMIN_CREATE_CQ_CMD_VIRT_MASK                   BIT(6)

#define EFA_ADMIN_CREATE_CQ_CMD_CQ_ENTRY_SIZE_WORDS_MASK    GENMASK(4, 0)



/* get_set_feature_common_desc */

#define EFA_ADMIN_GET_SET_FEATURE_COMMON_DESC_SELECT_MASK   GENMASK(1, 0)



/* feature_device_attr_desc */

#define EFA_ADMIN_FEATURE_DEVICE_ATTR_DESC_RDMA_READ_MASK   BIT(0)

#define EFA_ADMIN_FEATURE_DEVICE_ATTR_DESC_RNR_RETRY_MASK   BIT(1)