Commit 9bf3ac46 authored by Haibo Chen's avatar Haibo Chen Committed by Bartosz Golaszewski
Browse files

gpio: gpio-vf610: do not touch other bits when set the target bit 



For gpio controller contain register PDDR, when set one target bit,
current logic will clear all other bits, this is wrong. Use operator
'|=' to fix it.

Fixes: 659d8a62 ("gpio: vf610: add imx7ulp support")
Reviewed-by: default avatarPeng Fan <peng.fan@nxp.com>
Signed-off-by: default avatarHaibo Chen <haibo.chen@nxp.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 42226c98

drivers/gpio/gpio-vf610.c

+6 −2
Original line number Diff line number Diff line
@@ -125,9 +125,13 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, 
{

	struct vf610_gpio_port *port = gpiochip_get_data(chip);

	unsigned long mask = BIT(gpio);

	u32 val;



	if (port->sdata && port->sdata->have_paddr)

		vf610_gpio_writel(mask, port->gpio_base + GPIO_PDDR);

	if (port->sdata && port->sdata->have_paddr) {

		val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);

		val |= mask;

		vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);

	}



	vf610_gpio_set(chip, gpio, value);