Commit 9bbba563 authored by Liam Howlett's avatar Liam Howlett Committed by Andrew Morton
Browse files

maple_tree: fix depth tracking in maple_state 

It is possible to confuse the depth tracking in the maple state by
searching the same node for values.  Fix the depth tracking by moving
where the depth is incremented closer to where the node changes level. 
Also change the initial depth setting when using the root node.

Link: https://lkml.kernel.org/r/20221107163814.866612-1-Liam.Howlett@oracle.com


Signed-off-by: default avatarLiam R. Howlett <Liam.Howlett@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 1fdbed65

lib/maple_tree.c

+2 −1
Original line number Diff line number Diff line
@@ -1351,6 +1351,7 @@ static inline struct maple_enode *mas_start(struct ma_state *mas) 
		root = mas_root(mas);

		/* Tree with nodes */

		if (likely(xa_is_node(root))) {

			mas->depth = 1;

			mas->node = mte_safe_root(root);

			return NULL;

		}
@@ -3727,7 +3728,6 @@ static bool mas_is_span_wr(struct ma_wr_state *wr_mas) 


static inline void mas_wr_walk_descend(struct ma_wr_state *wr_mas)

{

	wr_mas->mas->depth++;

	wr_mas->type = mte_node_type(wr_mas->mas->node);

	mas_wr_node_walk(wr_mas);

	wr_mas->slots = ma_slots(wr_mas->node, wr_mas->type);
@@ -3739,6 +3739,7 @@ static inline void mas_wr_walk_traverse(struct ma_wr_state *wr_mas) 
	wr_mas->mas->min = wr_mas->r_min;

	wr_mas->mas->node = wr_mas->content;

	wr_mas->mas->offset = 0;

	wr_mas->mas->depth++;

}

/*

 * mas_wr_walk() - Walk the tree for a write.