Unverified Commit 9b65b2a8 authored by Amery Song's avatar Amery Song Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda: remove unnecessary ROM IPC filter function 



The HDA_DSP_IPC_PURGE_FW IPC from ROM is already handled in
cl_dsp_init(), and as IPC IRQ is disabled at this stage, this
IPC will be never received in the IRQ thread. The function
hda_dsp_ipc_is_sof for filtering the ROM IPC can be removed
safely.

Signed-off-by: default avatarAmery Song <chao.song@intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarKeyon <yang.jie@intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200312200622.24477-5-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a6096f88

sound/soc/sof/intel/hda-ipc.c

+3 −11
Original line number Diff line number Diff line
@@ -125,12 +125,6 @@ void hda_dsp_ipc_get_reply(struct snd_sof_dev *sdev) 


}



static bool hda_dsp_ipc_is_sof(uint32_t msg)

{

	return (msg & (HDA_DSP_IPC_PURGE_FW | 0xf << 9)) != msg ||

		(msg & HDA_DSP_IPC_PURGE_FW) != HDA_DSP_IPC_PURGE_FW;

}



/* IPC handler thread */

irqreturn_t hda_dsp_ipc_irq_thread(int irq, void *context)

{
@@ -176,11 +170,9 @@ irqreturn_t hda_dsp_ipc_irq_thread(int irq, void *context) 
		 */

		spin_lock_irq(&sdev->ipc_lock);



		/* handle immediate reply from DSP core - ignore ROM messages */

		if (hda_dsp_ipc_is_sof(msg)) {

		/* handle immediate reply from DSP core */

		hda_dsp_ipc_get_reply(sdev);

		snd_sof_ipc_reply(sdev, msg);

		}



		/* wake up sleeper if we are loading code */

		if (sdev->code_loading)	{