Commit 9b59588d authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Heiko Stuebner
Browse files

soc: rockchip: Fix refcount leak in rockchip_grf_init 



of_find_matching_node_and_match returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: 4c58063d ("soc: rockchip: add driver handling grf setup")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220516072013.19731-1-linmq006@gmail.com


Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent add9f6f3

drivers/soc/rockchip/grf.c

+2 −0
Original line number Diff line number Diff line
@@ -165,12 +165,14 @@ static int __init rockchip_grf_init(void) 
		return -ENODEV;

	if (!match || !match->data) {

		pr_err("%s: missing grf data\n", __func__);

		of_node_put(np);

		return -EINVAL;

	}



	grf_info = match->data;



	grf = syscon_node_to_regmap(np);

	of_node_put(np);

	if (IS_ERR(grf)) {

		pr_err("%s: could not get grf syscon\n", __func__);

		return PTR_ERR(grf);