Commit 9b51d072 authored by Xiongfeng Wang's avatar Xiongfeng Wang Committed by Leon Romanovsky
Browse files

RDMA/hfi: Decrease PCI device reference count in error path 



pci_get_device() will increase the reference count for the returned
pci_dev, and also decrease the reference count for the input parameter
*from* if it is not NULL.

If we break out the loop in node_affinity_init() with 'dev' not NULL, we
need to call pci_dev_put() to decrease the reference count. Add missing
pci_dev_put() in error path.

Fixes: c513de49 ("IB/hfi1: Invalid NUMA node information can cause a divide by zero")
Signed-off-by: default avatarXiongfeng Wang <wangxiongfeng2@huawei.com>
Link: https://lore.kernel.org/r/20221117131546.113280-1-wangxiongfeng2@huawei.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 2a402120

drivers/infiniband/hw/hfi1/affinity.c

+2 −0
Original line number Diff line number Diff line
@@ -177,6 +177,8 @@ int node_affinity_init(void) 
	for (node = 0; node < node_affinity.num_possible_nodes; node++)

		hfi1_per_node_cntr[node] = 1;



	pci_dev_put(dev);



	return 0;

}