Commit 9b3ee477 authored by Kalesh AP's avatar Kalesh AP Committed by Jason Gunthorpe
Browse files

RDMA/bnxt_re: Fix to remove unnecessary return labels 

If there is no cleanup needed then just return directly.  This cleans up
the code and improve readability.

Fixes: 1ac5a404 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
Link: https://lore.kernel.org/r/1684478897-12247-3-git-send-email-selvin.xavier@broadcom.com


Reviewed-by: default avatarKashyap Desai <kashyap.desai@broadcom.com>
Reviewed-by: default avatarSaravanan Vajravel <saravanan.vajravel@broadcom.com>
Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent ab112ee7

drivers/infiniband/hw/bnxt_re/qplib_fp.c

+2 −5
Original line number Diff line number Diff line
@@ -1618,7 +1618,7 @@ static int bnxt_qplib_put_inline(struct bnxt_qplib_qp *qp, 
		il_src = (void *)wqe->sg_list[indx].addr;

		t_len += len;

		if (t_len > qp->max_inline_data)

			goto bad;

			return -ENOMEM;

		while (len) {

			if (pull_dst) {

				pull_dst = false;
@@ -1642,8 +1642,6 @@ static int bnxt_qplib_put_inline(struct bnxt_qplib_qp *qp, 
	}



	return t_len;

bad:

	return -ENOMEM;

}



static u32 bnxt_qplib_put_sges(struct bnxt_qplib_hwq *hwq,
@@ -2067,7 +2065,7 @@ int bnxt_qplib_create_cq(struct bnxt_qplib_res *res, struct bnxt_qplib_cq *cq) 
	hwq_attr.sginfo = &cq->sg_info;

	rc = bnxt_qplib_alloc_init_hwq(&cq->hwq, &hwq_attr);

	if (rc)

		goto exit;

		return rc;



	bnxt_qplib_rcfw_cmd_prep((struct cmdq_base *)&req,

				 CMDQ_BASE_OPCODE_CREATE_CQ,
@@ -2115,7 +2113,6 @@ int bnxt_qplib_create_cq(struct bnxt_qplib_res *res, struct bnxt_qplib_cq *cq) 


fail:

	bnxt_qplib_free_hwq(res, &cq->hwq);

exit:

	return rc;

}