Commit 9acfc57f authored Dec 08, 2021 by José Expósito Committed by Jakub Kicinski Dec 09, 2021

net: mana: Fix memory leak in mana_hwc_create_wq



If allocating the DMA buffer fails, mana_hwc_destroy_wq was called
without previously storing the pointer to the queue.

In order to avoid leaking the pointer to the queue, store it as soon as
it is allocated.

Addresses-Coverity-ID: 1484720 ("Resource leak")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Link: https://lore.kernel.org/r/20211208223723.18520-1-jose.exposito89@gmail.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent ae68d933

drivers/net/ethernet/microsoft/mana/hw_channel.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -480,16 +480,16 @@ static int mana_hwc_create_wq(struct hw_channel_context *hwc,
		if (err)
		goto out;

		err = mana_hwc_alloc_dma_buf(hwc, q_depth, max_msg_size,
		&hwc_wq->msg_buf);
		if (err)
		goto out;

		hwc_wq->hwc = hwc;
		hwc_wq->gdma_wq = queue;
		hwc_wq->queue_depth = q_depth;
		hwc_wq->hwc_cq = hwc_cq;

		err = mana_hwc_alloc_dma_buf(hwc, q_depth, max_msg_size,
		&hwc_wq->msg_buf);
		if (err)
		goto out;

		*hwc_wq_ptr = hwc_wq;
		return 0;
		out: