Commit 9ab7b78a authored by Bob Peterson's avatar Bob Peterson Committed by Andreas Gruenbacher
Browse files

gfs2: simplify slot_get 



Simplify function slot_get and get rid of the goto that jumps into the
middle of an else branch.

Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent 8f190c97

fs/gfs2/quota.c

+9 −10
Original line number Diff line number Diff line
@@ -342,20 +342,19 @@ static int slot_get(struct gfs2_quota_data *qd) 
	int error = 0;



	spin_lock(&sdp->sd_bitmap_lock);

	if (qd->qd_slot_count != 0)

		goto out;



	if (qd->qd_slot_count == 0) {

		bit = find_first_zero_bit(sdp->sd_quota_bitmap,

					  sdp->sd_quota_slots);

		if (bit >= sdp->sd_quota_slots) {

			error = -ENOSPC;

	bit = find_first_zero_bit(sdp->sd_quota_bitmap, sdp->sd_quota_slots);

	if (bit < sdp->sd_quota_slots) {

			goto out;

		}

		set_bit(bit, sdp->sd_quota_bitmap);

		qd->qd_slot = bit;

		error = 0;

out:

		qd->qd_slot_count++;

	}

	qd->qd_slot_count++;

out:

	spin_unlock(&sdp->sd_bitmap_lock);



	return error;

}