Commit 9a4cea62 authored by Lucas De Marchi's avatar Lucas De Marchi
Browse files

drm/i915: ratelimit errors in display engine irq 



While debugging page table faults it's useful not to kill the machine
with thousands of error mesages. Ratelimit all errors in
gen8_de_irq_handler().

Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221215001459.3759580-1-lucas.demarchi@intel.com
parent 52f14682

drivers/gpu/drm/i915/i915_irq.c

+14 −14
Original line number Diff line number Diff line
@@ -2447,7 +2447,7 @@ gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl) 
			ret = IRQ_HANDLED;

			gen8_de_misc_irq_handler(dev_priv, iir);

		} else {

			drm_err(&dev_priv->drm,

			drm_err_ratelimited(&dev_priv->drm,

					    "The master control interrupt lied (DE MISC)!\n");

		}

	}
@@ -2459,7 +2459,7 @@ gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl) 
			ret = IRQ_HANDLED;

			gen11_hpd_irq_handler(dev_priv, iir);

		} else {

			drm_err(&dev_priv->drm,

			drm_err_ratelimited(&dev_priv->drm,

					    "The master control interrupt lied, (DE HPD)!\n");

		}

	}
@@ -2509,11 +2509,11 @@ gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl) 
			}



			if (!found)

				drm_err(&dev_priv->drm,

				drm_err_ratelimited(&dev_priv->drm,

						    "Unexpected DE Port interrupt\n");

		}

		else

			drm_err(&dev_priv->drm,

			drm_err_ratelimited(&dev_priv->drm,

					    "The master control interrupt lied (DE PORT)!\n");

	}
@@ -2525,7 +2525,7 @@ gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl) 


		iir = intel_uncore_read(&dev_priv->uncore, GEN8_DE_PIPE_IIR(pipe));

		if (!iir) {

			drm_err(&dev_priv->drm,

			drm_err_ratelimited(&dev_priv->drm,

					    "The master control interrupt lied (DE PIPE)!\n");

			continue;

		}
@@ -2547,7 +2547,7 @@ gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl) 


		fault_errors = iir & gen8_de_pipe_fault_mask(dev_priv);

		if (fault_errors)

			drm_err(&dev_priv->drm,

			drm_err_ratelimited(&dev_priv->drm,

					    "Fault errors on pipe %c: 0x%08x\n",

					    pipe_name(pipe),

					    fault_errors);