Commit 9a3bc77e authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

bnxt_en: Properly report no pause support on some cards 



Some cards are configured to never support link pause or PFC.  Discover
these cards and properly report no pause support to ethtool.  Disable
PFC settings from DCBNL if PFC is unsupported.

Reviewed-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0f5a4841

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −1
Original line number Diff line number Diff line
@@ -9416,7 +9416,7 @@ static int bnxt_hwrm_phy_qcaps(struct bnxt *bp) 
	if (rc)

		goto hwrm_phy_qcaps_exit;



	bp->phy_flags = resp->flags;

	bp->phy_flags = resp->flags | (le16_to_cpu(resp->flags2) << 8);

	if (resp->flags & PORT_PHY_QCAPS_RESP_FLAGS_EEE_SUPPORTED) {

		struct ethtool_eee *eee = &bp->eee;

		u16 fw_speeds = le16_to_cpu(resp->supported_speeds_eee_mode);

drivers/net/ethernet/broadcom/bnxt/bnxt.h

+4 −2
Original line number Diff line number Diff line
@@ -2104,8 +2104,8 @@ struct bnxt { 
	u32			lpi_tmr_lo;

	u32			lpi_tmr_hi;



	/* copied from flags in hwrm_port_phy_qcaps_output */

	u8			phy_flags;

	/* copied from flags and flags2 in hwrm_port_phy_qcaps_output */

	u32			phy_flags;

#define BNXT_PHY_FL_EEE_CAP		PORT_PHY_QCAPS_RESP_FLAGS_EEE_SUPPORTED

#define BNXT_PHY_FL_EXT_LPBK		PORT_PHY_QCAPS_RESP_FLAGS_EXTERNAL_LPBK_SUPPORTED

#define BNXT_PHY_FL_AN_PHY_LPBK		PORT_PHY_QCAPS_RESP_FLAGS_AUTONEG_LPBK_SUPPORTED
@@ -2114,6 +2114,8 @@ struct bnxt { 
#define BNXT_PHY_FL_NO_PHY_LPBK		PORT_PHY_QCAPS_RESP_FLAGS_LOCAL_LPBK_NOT_SUPPORTED

#define BNXT_PHY_FL_FW_MANAGED_LKDN	PORT_PHY_QCAPS_RESP_FLAGS_FW_MANAGED_LINK_DOWN

#define BNXT_PHY_FL_NO_FCS		PORT_PHY_QCAPS_RESP_FLAGS_NO_FCS

#define BNXT_PHY_FL_NO_PAUSE		(PORT_PHY_QCAPS_RESP_FLAGS2_PAUSE_UNSUPPORTED << 8)

#define BNXT_PHY_FL_NO_PFC		(PORT_PHY_QCAPS_RESP_FLAGS2_PFC_UNSUPPORTED << 8)



	u8			num_tests;

	struct bnxt_test_info	*test_info;

drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c

+2 −1
Original line number Diff line number Diff line
@@ -627,7 +627,8 @@ static int bnxt_dcbnl_ieee_setpfc(struct net_device *dev, struct ieee_pfc *pfc) 
	int rc;



	if (!(bp->dcbx_cap & DCB_CAP_DCBX_VER_IEEE) ||

	    !(bp->dcbx_cap & DCB_CAP_DCBX_HOST))

	    !(bp->dcbx_cap & DCB_CAP_DCBX_HOST) ||

	    (bp->phy_flags & BNXT_PHY_FL_NO_PAUSE))

		return -EINVAL;



	if (!my_pfc) {

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+10 −5
Original line number Diff line number Diff line
@@ -1662,15 +1662,19 @@ static void bnxt_fw_to_ethtool_support_fec(struct bnxt_link_info *link_info, 
static void bnxt_fw_to_ethtool_support_spds(struct bnxt_link_info *link_info,

				struct ethtool_link_ksettings *lk_ksettings)

{

	struct bnxt *bp = container_of(link_info, struct bnxt, link_info);

	u16 fw_speeds = link_info->support_speeds;



	BNXT_FW_TO_ETHTOOL_SPDS(fw_speeds, 0, lk_ksettings, supported);

	fw_speeds = link_info->support_pam4_speeds;

	BNXT_FW_TO_ETHTOOL_PAM4_SPDS(fw_speeds, lk_ksettings, supported);



	ethtool_link_ksettings_add_link_mode(lk_ksettings, supported, Pause);

	if (!(bp->phy_flags & BNXT_PHY_FL_NO_PAUSE)) {

		ethtool_link_ksettings_add_link_mode(lk_ksettings, supported,

						     Pause);

		ethtool_link_ksettings_add_link_mode(lk_ksettings, supported,

						     Asym_Pause);

	}



	if (link_info->support_auto_speeds ||

	    link_info->support_pam4_auto_speeds)
@@ -1901,6 +1905,7 @@ static int bnxt_set_link_ksettings(struct net_device *dev, 
		/* any change to autoneg will cause link change, therefore the

		 * driver should put back the original pause setting in autoneg

		 */

		if (!(bp->phy_flags & BNXT_PHY_FL_NO_PAUSE))

			set_pause = true;

	} else {

		u8 phy_type = link_info->phy_type;
@@ -2093,7 +2098,7 @@ static int bnxt_set_pauseparam(struct net_device *dev, 
	struct bnxt *bp = netdev_priv(dev);

	struct bnxt_link_info *link_info = &bp->link_info;



	if (!BNXT_PHY_CFG_ABLE(bp))

	if (!BNXT_PHY_CFG_ABLE(bp) || (bp->phy_flags & BNXT_PHY_FL_NO_PAUSE))

		return -EOPNOTSUPP;



	mutex_lock(&bp->link_lock);