Commit 9a318b8b authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans de Goede
Browse files

platform/x86: xo1-rfkill: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230302144732.1903781-30-u.kleine-koenig@pengutronix.de


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 0f16136b

drivers/platform/x86/xo1-rfkill.c

+2 −3
Original line number Diff line number Diff line
@@ -56,12 +56,11 @@ static int xo1_rfkill_probe(struct platform_device *pdev) 
	return 0;

}



static int xo1_rfkill_remove(struct platform_device *pdev)

static void xo1_rfkill_remove(struct platform_device *pdev)

{

	struct rfkill *rfk = platform_get_drvdata(pdev);

	rfkill_unregister(rfk);

	rfkill_destroy(rfk);

	return 0;

}



static struct platform_driver xo1_rfkill_driver = {
@@ -69,7 +68,7 @@ static struct platform_driver xo1_rfkill_driver = { 
		.name = "xo1-rfkill",

	},

	.probe		= xo1_rfkill_probe,

	.remove		= xo1_rfkill_remove,

	.remove_new	= xo1_rfkill_remove,

};



module_platform_driver(xo1_rfkill_driver);