Commit 99df80c7 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/sstfb: Use fbdev I/O helpers 



Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
	* use _IOMEM_ in commit message
v2:
	* updated to use _IOMEM_ tokens

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarHelge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-41-tzimmermann@suse.de
parent 367984eb

drivers/video/fbdev/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -1340,9 +1340,7 @@ config FB_VOODOO1 
	tristate "3Dfx Voodoo Graphics (sst1) support"

	depends on FB && PCI

	depends on FB_DEVICE

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_HELPERS

	select VIDEO_NOMODESET

	help

	  Say Y here if you have a 3Dfx Voodoo Graphics (Voodoo1/sst1) or

drivers/video/fbdev/sstfb.c

+1 −3
Original line number Diff line number Diff line
@@ -1310,12 +1310,10 @@ static int sstfb_setup(char *options) 


static const struct fb_ops sstfb_ops = {

	.owner		= THIS_MODULE,

	FB_DEFAULT_IOMEM_OPS,

	.fb_check_var	= sstfb_check_var,

	.fb_set_par	= sstfb_set_par,

	.fb_setcolreg	= sstfb_setcolreg,

	.fb_fillrect	= cfb_fillrect, /* sstfb_fillrect */

	.fb_copyarea	= cfb_copyarea, /* sstfb_copyarea */

	.fb_imageblit	= cfb_imageblit,

	.fb_ioctl	= sstfb_ioctl,

};