Unverified Commit 99cc528e authored by Maíra Canal's avatar Maíra Canal Committed by Maíra Canal
Browse files

drm/vkms: Use drmm_crtc_init_with_planes() 



Use drmm_crtc_init_with_planes() instead of drm_crtc_init_with_planes()
to get rid of the explicit destroy hook in struct drm_crtc_funcs.

Signed-off-by: default avatarMaíra Canal <mcanal@igalia.com>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Signed-off-by: default avatarMaíra Canal <mairacanal@riseup.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20230116205800.1266227-1-mcanal@igalia.com
parent bfa8342c

drivers/gpu/drm/vkms/vkms_crtc.c

+2 −3
Original line number Diff line number Diff line
@@ -161,7 +161,6 @@ static void vkms_atomic_crtc_reset(struct drm_crtc *crtc) 


static const struct drm_crtc_funcs vkms_crtc_funcs = {

	.set_config             = drm_atomic_helper_set_config,

	.destroy                = drm_crtc_cleanup,

	.page_flip              = drm_atomic_helper_page_flip,

	.reset                  = vkms_atomic_crtc_reset,

	.atomic_duplicate_state = vkms_atomic_crtc_duplicate_state,
@@ -282,7 +281,7 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, 
	struct vkms_output *vkms_out = drm_crtc_to_vkms_output(crtc);

	int ret;



	ret = drm_crtc_init_with_planes(dev, crtc, primary, cursor,

	ret = drmm_crtc_init_with_planes(dev, crtc, primary, cursor,

					 &vkms_crtc_funcs, NULL);

	if (ret) {

		DRM_ERROR("Failed to init CRTC\n");