Commit 99c31bff authored by Sunil V L's avatar Sunil V L Committed by Rafael J. Wysocki
Browse files

PNP: ACPI: Fix string truncation warning 



LKP reports below warning when building for RISC-V.

drivers/pnp/pnpacpi/core.c:253:17:
warning: 'strncpy' specified bound 50 equals destination
size [-Wstringop-truncation]

This appears to be a valid issue since the destination string may not be
null-terminated.

To fix this, append the NUL explicitly after the strncpy().

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307241942.Rff2Nri5-lkp@intel.com/


Signed-off-by: default avatarSunil V L <sunilvl@ventanamicro.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 2ccdd1b1

drivers/pnp/pnpacpi/core.c

+3 −0
Original line number Diff line number Diff line
@@ -254,6 +254,9 @@ static int __init pnpacpi_add_device(struct acpi_device *device) 
	else

		strncpy(dev->name, acpi_device_bid(device), sizeof(dev->name));



	/* Handle possible string truncation */

	dev->name[sizeof(dev->name) - 1] = '\0';



	if (dev->active)

		pnpacpi_parse_allocated_resource(dev);