Commit 99a5483c authored by Breno Leitao's avatar Breno Leitao Committed by Yuan Can
Browse files

i2c: tegra: Do not mark ACPI devices as irq safe 

stable inclusion
from stable-v6.6.48
commit 6861faf4232e4b78878f2de1ed3ee324ddae2287
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IAQOJB
CVE: CVE-2024-45029

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=6861faf4232e4b78878f2de1ed3ee324ddae2287



--------------------------------

commit 14d069d92951a3e150c0a81f2ca3b93e54da913b upstream.

On ACPI machines, the tegra i2c module encounters an issue due to a
mutex being called inside a spinlock. This leads to the following bug:

	BUG: sleeping function called from invalid context at kernel/locking/mutex.c:585
	...

	Call trace:
	__might_sleep
	__mutex_lock_common
	mutex_lock_nested
	acpi_subsys_runtime_resume
	rpm_resume
	tegra_i2c_xfer

The problem arises because during __pm_runtime_resume(), the spinlock
&dev->power.lock is acquired before rpm_resume() is called. Later,
rpm_resume() invokes acpi_subsys_runtime_resume(), which relies on
mutexes, triggering the error.

To address this issue, devices on ACPI are now marked as not IRQ-safe,
considering the dependency of acpi_subsys_runtime_resume() on mutexes.

Fixes: bd2fdedb ("i2c: tegra: Add the ACPI support")
Cc: <stable@vger.kernel.org> # v5.17+
Co-developed-by: default avatarMichael van der Westhuizen <rmikey@meta.com>
Signed-off-by: default avatarMichael van der Westhuizen <rmikey@meta.com>
Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarDmitry Osipenko <digetx@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
parent 81a41d2a

drivers/i2c/busses/i2c-tegra.c

+2 −2
Original line number Diff line number Diff line
@@ -1804,9 +1804,9 @@ static int tegra_i2c_probe(struct platform_device *pdev) 
	 * domain.

	 *

	 * VI I2C device shouldn't be marked as IRQ-safe because VI I2C won't

	 * be used for atomic transfers.

	 * be used for atomic transfers. ACPI device is not IRQ safe also.

	 */

	if (!IS_VI(i2c_dev))

	if (!IS_VI(i2c_dev) && !has_acpi_companion(i2c_dev->dev))

		pm_runtime_irq_safe(i2c_dev->dev);



	pm_runtime_enable(i2c_dev->dev);