Commit 99984b08 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Greg Kroah-Hartman
Browse files

usb: gadget: u_ether: use eth_hw_addr_set() 



Commit 406f42fa ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Reviewed-by: default avatarMaciej Żenczykowski <maze@google.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20211019172124.1413620-1-kuba@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6e4d56db

drivers/usb/gadget/function/u_ether.c

+3 −1
Original line number Diff line number Diff line
@@ -754,6 +754,7 @@ struct eth_dev *gether_setup_name(struct usb_gadget *g, 
	struct eth_dev		*dev;

	struct net_device	*net;

	int			status;

	u8			addr[ETH_ALEN];



	net = alloc_etherdev(sizeof *dev);

	if (!net)
@@ -773,9 +774,10 @@ struct eth_dev *gether_setup_name(struct usb_gadget *g, 
	dev->qmult = qmult;

	snprintf(net->name, sizeof(net->name), "%s%%d", netname);



	if (get_ether_addr(dev_addr, net->dev_addr))

	if (get_ether_addr(dev_addr, addr))

		dev_warn(&g->dev,

			"using random %s ethernet address\n", "self");

	eth_hw_addr_set(net, addr);

	if (get_ether_addr(host_addr, dev->host_mac))

		dev_warn(&g->dev,

			"using random %s ethernet address\n", "host");