Commit 998c49e8 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

pinctrl: intel: Drop unnecessary check for predefined features 



None of the drivers is overriding features. Remove unnecessary check.
While here, rename rev to value to make easier further development.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent 036e126c

drivers/pinctrl/intel/pinctrl-intel.c

+6 −12
Original line number Diff line number Diff line
@@ -1473,6 +1473,7 @@ static int intel_pinctrl_probe(struct platform_device *pdev, 
		struct intel_community *community = &pctrl->communities[i];

		void __iomem *regs;

		u32 padbar;

		u32 value;



		*community = pctrl->soc->communities[i];
@@ -1480,19 +1481,12 @@ static int intel_pinctrl_probe(struct platform_device *pdev, 
		if (IS_ERR(regs))

			return PTR_ERR(regs);



		/*

		 * Determine community features based on the revision if

		 * not specified already.

		 */

		if (!community->features) {

			u32 rev;



			rev = (readl(regs + REVID) & REVID_MASK) >> REVID_SHIFT;

			if (rev >= 0x94) {

		/* Determine community features based on the revision */

		value = readl(regs + REVID);

		if (((value & REVID_MASK) >> REVID_SHIFT) >= 0x94) {

			community->features |= PINCTRL_FEATURE_DEBOUNCE;

			community->features |= PINCTRL_FEATURE_1K_PD;

		}

		}



		/* Read offset of the pad configuration registers */

		padbar = readl(regs + PADBAR);