Commit 99719449 authored by Nigel Christian's avatar Nigel Christian Committed by Marcel Holtmann
Browse files

Bluetooth: hci_qca: resolve various warnings 

Replace symbolic permissions with octal values. Use usleep_range
for small msec values due to the fact that msleep() less than
20ms may have unexpected behavior/sleep longer.

- https://lkml.org/lkml/2016/8/2/1945


- Documentation/timers/timers-howto.rst

Signed-off-by: default avatarNigel Christian <nigel.l.christian@gmail.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 9e80587a

drivers/bluetooth/hci_qca.c

+4 −4
Original line number Diff line number Diff line
@@ -631,7 +631,7 @@ static void qca_debugfs_init(struct hci_dev *hdev) 
	ibs_dir = debugfs_create_dir("ibs", hdev->debugfs);



	/* read only */

	mode = S_IRUGO;

	mode = 0444;

	debugfs_create_u8("tx_ibs_state", mode, ibs_dir, &qca->tx_ibs_state);

	debugfs_create_u8("rx_ibs_state", mode, ibs_dir, &qca->rx_ibs_state);

	debugfs_create_u64("ibs_sent_sleeps", mode, ibs_dir,
@@ -658,7 +658,7 @@ static void qca_debugfs_init(struct hci_dev *hdev) 
	debugfs_create_u32("vote_off_ms", mode, ibs_dir, &qca->vote_off_ms);



	/* read/write */

	mode = S_IRUGO | S_IWUSR;

	mode = 0644;

	debugfs_create_u32("wake_retrans", mode, ibs_dir, &qca->wake_retrans);

	debugfs_create_u32("tx_idle_delay", mode, ibs_dir,

			   &qca->tx_idle_delay);
@@ -1302,7 +1302,7 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate) 


	/* Give the controller time to process the request */

	if (qca_is_wcn399x(qca_soc_type(hu)))

		msleep(10);

		usleep_range(1000, 10000);

	else

		msleep(300);
@@ -1350,7 +1350,7 @@ static int qca_send_power_pulse(struct hci_uart *hu, bool on) 
	if (on)

		msleep(100);

	else

		msleep(10);

		usleep_range(1000, 10000);



	return 0;

}