Commit 99241e11 authored by Jackie Liu's avatar Jackie Liu Committed by Martin K. Petersen
Browse files

scsi: core: sysfs: Remove comments that conflict with the actual logic 

Christoph Hellwig Says:
=======================
I think we should just handle the error properly and remove the comment.
There's no good reason to ignore bsg registration errors.

In fact, after commit 92c4b58b ("scsi: core: Register sysfs attributes
earlier"), we are already forced to return errno.

We discuss this issue in [1].

[1] https://lore.kernel.org/all/20211022010201.426746-1-liu.yun@linux.dev/

Link: https://lore.kernel.org/r/20220329021251.123805-1-liu.yun@linux.dev


Suggested-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJackie Liu <liuyun01@kylinos.cn>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 066f4c31

drivers/scsi/scsi_sysfs.c

+0 −4
Original line number Diff line number Diff line
@@ -1384,10 +1384,6 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev) 
	if (IS_ENABLED(CONFIG_BLK_DEV_BSG)) {

		sdev->bsg_dev = scsi_bsg_register_queue(sdev);

		if (IS_ERR(sdev->bsg_dev)) {

			/*

			 * We're treating error on bsg register as non-fatal, so

			 * pretend nothing went wrong.

			 */

			error = PTR_ERR(sdev->bsg_dev);

			sdev_printk(KERN_INFO, sdev,

				    "Failed to register bsg queue, errno=%d\n",