Commit 991be636 authored by Bui Quang Minh's avatar Bui Quang Minh Committed by Yuan Can
Browse files

scsi: bfa: Ensure the copied buf is NUL terminated

mainline inclusion
from mainline-v6.10-rc1
commit 13d0cecb4626fae67c00c84d3c7851f6b62f7df3
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IA6SFW
CVE: CVE-2024-38560

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=13d0cecb4626fae67c00c84d3c7851f6b62f7df3



--------------------------------

[ Upstream commit 13d0cecb4626fae67c00c84d3c7851f6b62f7df3 ]

Currently, we allocate a nbytes-sized kernel buffer and copy nbytes from
userspace to that buffer. Later, we use sscanf on this buffer but we don't
ensure that the string is terminated inside the buffer, this can lead to
OOB read when using sscanf. Fix this issue by using memdup_user_nul instead
of memdup_user.

Fixes: 9f30b674 ("bfa: replace 2 kzalloc/copy_from_user by memdup_user")
Signed-off-by: default avatarBui Quang Minh <minhquangbui99@gmail.com>
Link: https://lore.kernel.org/r/20240424-fix-oob-read-v2-3-f1f1b53a10f4@gmail.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
parent 7969c980
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment