Commit 990fc368 authored Jan 26, 2021 by Pierre-Louis Bossart Committed by sanglipeng Feb 22, 2024

soundwire: bus: add better dev_dbg to track complete() calls

stable inclusion
from stable-v5.10.190
commit 662735bc11279f474c8abfd6c8d4faeddd08f359
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I928UI

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=662735bc11279f474c8abfd6c8d4faeddd08f359



--------------------------------

[ Upstream commit f1b69026 ]

Add a dev_dbg() log for both enumeration and initialization completion
to better track suspend-resume issues.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Chao Song <chao.song@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210126085402.4264-1-yung-chuan.liao@linux.intel.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>
Stable-dep-of: c40d6b32 ("soundwire: fix enumeration completion")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: sanglipeng <sanglipeng1@jd.com>

parent 62c59710

drivers/soundwire/bus.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -797,7 +797,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,

		if (status == SDW_SLAVE_UNATTACHED) {
		dev_dbg(&slave->dev,
		"%s: initializing completion for Slave %d\n",
		"%s: initializing enumeration and init completion for Slave %d\n",
		__func__, slave->dev_num);

		init_completion(&slave->enumeration_complete);
		@@ -806,7 +806,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,
		} else if ((status == SDW_SLAVE_ATTACHED) &&
		(slave->status == SDW_SLAVE_UNATTACHED)) {
		dev_dbg(&slave->dev,
		"%s: signaling completion for Slave %d\n",
		"%s: signaling enumeration completion for Slave %d\n",
		__func__, slave->dev_num);

		complete(&slave->enumeration_complete);
		@@ -1734,9 +1734,14 @@ int sdw_handle_slave_status(struct sdw_bus *bus,
		if (ret)
		dev_err(slave->bus->dev,
		"Update Slave status failed:%d\n", ret);
		if (attached_initializing)
		if (attached_initializing) {
		dev_dbg(&slave->dev,
		"%s: signaling initialization completion for Slave %d\n",
		__func__, slave->dev_num);

		complete(&slave->initialization_complete);
		}
		}

		return ret;
		}