Commit 98ff4c7c authored by Jonathan Cooper's avatar Jonathan Cooper Committed by David S. Miller
Browse files

sfc: Separate netdev probe/remove from PCI probe/remove 



The netdev probe will be used when moving from vDPA to EF100 BAR config.
The netdev remove will be used when moving from EF100 to vDPA BAR config.

In the process, change several log messages to pci_ instead of netif_
to remove the "(unregistered net_device)" text.

Signed-off-by: default avatarJonathan Cooper <jonathan.s.cooper@amd.com>
Co-developed-by: default avatarMartin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: default avatarMartin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7592d754

drivers/net/ethernet/sfc/ef100.c

+20 −45
Original line number Diff line number Diff line
@@ -423,44 +423,32 @@ static int ef100_pci_find_func_ctrl_window(struct efx_nic *efx, 
 */

static void ef100_pci_remove(struct pci_dev *pci_dev)

{

	struct efx_nic *efx = pci_get_drvdata(pci_dev);

	struct efx_probe_data *probe_data;

	struct efx_nic *efx;



	efx = pci_get_drvdata(pci_dev);

	if (!efx)

		return;



	rtnl_lock();

	dev_close(efx->net_dev);

	rtnl_unlock();

	probe_data = container_of(efx, struct efx_probe_data, efx);

	ef100_remove_netdev(probe_data);



	/* Unregistering our netdev notifier triggers unbinding of TC indirect

	 * blocks, so we have to do it before PCI removal.

	 */

	unregister_netdevice_notifier(&efx->netdev_notifier);

#if defined(CONFIG_SFC_SRIOV)

	if (!efx->type->is_vf)

		efx_ef100_pci_sriov_disable(efx);

#endif

	ef100_remove(efx);

	efx_fini_io(efx);

	netif_dbg(efx, drv, efx->net_dev, "shutdown successful\n");



	pci_dbg(pci_dev, "shutdown successful\n");



	pci_disable_pcie_error_reporting(pci_dev);



	pci_set_drvdata(pci_dev, NULL);

	efx_fini_struct(efx);

	free_netdev(efx->net_dev);

	probe_data = container_of(efx, struct efx_probe_data, efx);

	kfree(probe_data);



	pci_disable_pcie_error_reporting(pci_dev);

};



static int ef100_pci_probe(struct pci_dev *pci_dev,

			   const struct pci_device_id *entry)

{

	struct efx_probe_data *probe_data, **probe_ptr;

	struct ef100_func_ctl_window fcw = { 0 };

	struct net_device *net_dev;

	struct efx_probe_data *probe_data;

	struct efx_nic *efx;

	int rc;
@@ -471,29 +459,20 @@ static int ef100_pci_probe(struct pci_dev *pci_dev, 
	probe_data->pci_dev = pci_dev;

	efx = &probe_data->efx;



	/* Allocate and initialise a struct net_device */

	net_dev = alloc_etherdev_mq(sizeof(probe_data), EFX_MAX_CORE_TX_QUEUES);

	if (!net_dev)

		return -ENOMEM;

	probe_ptr = netdev_priv(net_dev);

	*probe_ptr = probe_data;

	efx->type = (const struct efx_nic_type *)entry->driver_data;



	efx->pci_dev = pci_dev;

	pci_set_drvdata(pci_dev, efx);

	SET_NETDEV_DEV(net_dev, &pci_dev->dev);

	efx->net_dev = net_dev;

	rc = efx_init_struct(efx, pci_dev);

	if (rc)

		goto fail;



	efx->mdio.dev = net_dev;

	efx->vi_stride = EF100_DEFAULT_VI_STRIDE;

	netif_info(efx, probe, efx->net_dev,

		   "Solarflare EF100 NIC detected\n");

	pci_info(pci_dev, "Solarflare EF100 NIC detected\n");



	rc = ef100_pci_find_func_ctrl_window(efx, &fcw);

	if (rc) {

		netif_err(efx, probe, efx->net_dev,

		pci_err(pci_dev,

			"Error looking for ef100 function control window, rc=%d\n",

			rc);

		goto fail;
@@ -507,8 +486,7 @@ static int ef100_pci_probe(struct pci_dev *pci_dev, 
	}



	if (fcw.offset > pci_resource_len(efx->pci_dev, fcw.bar) - ESE_GZ_FCW_LEN) {

		netif_err(efx, probe, efx->net_dev,

			  "Func control window overruns BAR\n");

		pci_err(pci_dev, "Func control window overruns BAR\n");

		rc = -EIO;

		goto fail;

	}
@@ -522,19 +500,16 @@ static int ef100_pci_probe(struct pci_dev *pci_dev, 


	efx->reg_base = fcw.offset;



	efx->netdev_notifier.notifier_call = ef100_netdev_event;

	rc = register_netdevice_notifier(&efx->netdev_notifier);

	if (rc) {

		netif_err(efx, probe, efx->net_dev,

			  "Failed to register netdevice notifier, rc=%d\n", rc);

	rc = efx->type->probe(efx);

	if (rc)

		goto fail;

	}



	rc = efx->type->probe(efx);

	efx->state = STATE_PROBED;

	rc = ef100_probe_netdev(probe_data);

	if (rc)

		goto fail;



	netif_dbg(efx, probe, efx->net_dev, "initialisation successful\n");

	pci_dbg(pci_dev, "initialisation successful\n");



	return 0;

drivers/net/ethernet/sfc/ef100_netdev.c

+113 −3
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ 
#include "ef100_regs.h"

#include "mcdi_filters.h"

#include "rx_common.h"

#include "ef100_sriov.h"



static void ef100_update_name(struct efx_nic *efx)

{
@@ -243,13 +244,14 @@ int ef100_netdev_event(struct notifier_block *this, 
	struct efx_nic *efx = container_of(this, struct efx_nic, netdev_notifier);

	struct net_device *net_dev = netdev_notifier_info_to_dev(ptr);



	if (efx->net_dev == net_dev && event == NETDEV_CHANGENAME)

	if (efx->net_dev == net_dev &&

	    (event == NETDEV_CHANGENAME || event == NETDEV_REGISTER))

		ef100_update_name(efx);



	return NOTIFY_DONE;

}



int ef100_register_netdev(struct efx_nic *efx)

static int ef100_register_netdev(struct efx_nic *efx)

{

	struct net_device *net_dev = efx->net_dev;

	int rc;
@@ -287,7 +289,7 @@ int ef100_register_netdev(struct efx_nic *efx) 
	return rc;

}



void ef100_unregister_netdev(struct efx_nic *efx)

static void ef100_unregister_netdev(struct efx_nic *efx)

{

	if (efx_dev_registered(efx)) {

		efx_fini_mcdi_logging(efx);
@@ -295,3 +297,111 @@ void ef100_unregister_netdev(struct efx_nic *efx) 
		unregister_netdev(efx->net_dev);

	}

}



void ef100_remove_netdev(struct efx_probe_data *probe_data)

{

	struct efx_nic *efx = &probe_data->efx;



	if (!efx->net_dev)

		return;



	rtnl_lock();

	dev_close(efx->net_dev);

	rtnl_unlock();



	unregister_netdevice_notifier(&efx->netdev_notifier);

#if defined(CONFIG_SFC_SRIOV)

	if (!efx->type->is_vf)

		efx_ef100_pci_sriov_disable(efx);

#endif



	ef100_unregister_netdev(efx);



	down_write(&efx->filter_sem);

	efx_mcdi_filter_table_remove(efx);

	up_write(&efx->filter_sem);

	efx_fini_channels(efx);

	kfree(efx->phy_data);

	efx->phy_data = NULL;



	free_netdev(efx->net_dev);

	efx->net_dev = NULL;

	efx->state = STATE_PROBED;

}



int ef100_probe_netdev(struct efx_probe_data *probe_data)

{

	struct efx_nic *efx = &probe_data->efx;

	struct efx_probe_data **probe_ptr;

	struct net_device *net_dev;

	int rc;



	if (efx->mcdi->fn_flags &

			(1 << MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_NO_ACTIVE_PORT)) {

		pci_info(efx->pci_dev, "No network port on this PCI function");

		return 0;

	}



	/* Allocate and initialise a struct net_device */

	net_dev = alloc_etherdev_mq(sizeof(probe_data), EFX_MAX_CORE_TX_QUEUES);

	if (!net_dev)

		return -ENOMEM;

	probe_ptr = netdev_priv(net_dev);

	*probe_ptr = probe_data;

	efx->net_dev = net_dev;

	SET_NETDEV_DEV(net_dev, &efx->pci_dev->dev);



	net_dev->features |= efx->type->offload_features;

	net_dev->hw_features |= efx->type->offload_features;

	net_dev->hw_enc_features |= efx->type->offload_features;

	net_dev->vlan_features |= NETIF_F_HW_CSUM | NETIF_F_SG |

				  NETIF_F_HIGHDMA | NETIF_F_ALL_TSO;

	netif_set_tso_max_segs(net_dev,

			       ESE_EF100_DP_GZ_TSO_MAX_HDR_NUM_SEGS_DEFAULT);

	efx->mdio.dev = net_dev;



	rc = efx_ef100_init_datapath_caps(efx);

	if (rc < 0)

		goto fail;



	rc = ef100_phy_probe(efx);

	if (rc)

		goto fail;



	rc = efx_init_channels(efx);

	if (rc)

		goto fail;



	down_write(&efx->filter_sem);

	rc = ef100_filter_table_probe(efx);

	up_write(&efx->filter_sem);

	if (rc)

		goto fail;



	netdev_rss_key_fill(efx->rss_context.rx_hash_key,

			    sizeof(efx->rss_context.rx_hash_key));



	/* Don't fail init if RSS setup doesn't work. */

	efx_mcdi_push_default_indir_table(efx, efx->n_rx_channels);



	rc = ef100_register_netdev(efx);

	if (rc)

		goto fail;



	if (!efx->type->is_vf) {

		rc = ef100_probe_netdev_pf(efx);

		if (rc)

			goto fail;

	}



	efx->netdev_notifier.notifier_call = ef100_netdev_event;

	rc = register_netdevice_notifier(&efx->netdev_notifier);

	if (rc) {

		netif_err(efx, probe, efx->net_dev,

			  "Failed to register netdevice notifier, rc=%d\n", rc);

		goto fail;

	}



fail:

	return rc;

}

drivers/net/ethernet/sfc/ef100_netdev.h

+2 −2
Original line number Diff line number Diff line
@@ -13,5 +13,5 @@ 


int ef100_netdev_event(struct notifier_block *this,

		       unsigned long event, void *ptr);

int ef100_register_netdev(struct efx_nic *efx);

void ef100_unregister_netdev(struct efx_nic *efx);
 
int ef100_probe_netdev(struct efx_probe_data *probe_data);

void ef100_remove_netdev(struct efx_probe_data *probe_data);

drivers/net/ethernet/sfc/ef100_nic.c

+14 −66
Original line number Diff line number Diff line
@@ -148,7 +148,7 @@ static int ef100_get_mac_address(struct efx_nic *efx, u8 *mac_address) 
	return 0;

}



static int efx_ef100_init_datapath_caps(struct efx_nic *efx)

int efx_ef100_init_datapath_caps(struct efx_nic *efx)

{

	MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_CAPABILITIES_V7_OUT_LEN);

	struct ef100_nic_data *nic_data = efx->nic_data;
@@ -327,7 +327,7 @@ static irqreturn_t ef100_msi_interrupt(int irq, void *dev_id) 
	return IRQ_HANDLED;

}



static int ef100_phy_probe(struct efx_nic *efx)

int ef100_phy_probe(struct efx_nic *efx)

{

	struct efx_mcdi_phy_data *phy_data;

	int rc;
@@ -365,7 +365,7 @@ static int ef100_phy_probe(struct efx_nic *efx) 
	return 0;

}



static int ef100_filter_table_probe(struct efx_nic *efx)

int ef100_filter_table_probe(struct efx_nic *efx)

{

	return efx_mcdi_filter_table_probe(efx, true);

}
@@ -905,8 +905,7 @@ static int ef100_check_design_params(struct efx_nic *efx) 


	efx_readd(efx, &reg, ER_GZ_PARAMS_TLV_LEN);

	total_len = EFX_DWORD_FIELD(reg, EFX_DWORD_0);

	netif_dbg(efx, probe, efx->net_dev, "%u bytes of design parameters\n",

		  total_len);

	pci_dbg(efx->pci_dev, "%u bytes of design parameters\n", total_len);

	while (offset < total_len) {

		efx_readd(efx, &reg, ER_GZ_PARAMS_TLV + offset);

		data = EFX_DWORD_FIELD(reg, EFX_DWORD_0);
@@ -945,7 +944,6 @@ static int ef100_check_design_params(struct efx_nic *efx) 
static int ef100_probe_main(struct efx_nic *efx)

{

	unsigned int bar_size = resource_size(&efx->pci_dev->resource[efx->mem_bar]);

	struct net_device *net_dev = efx->net_dev;

	struct ef100_nic_data *nic_data;

	char fw_version[32];

	int i, rc;
@@ -958,24 +956,18 @@ static int ef100_probe_main(struct efx_nic *efx) 
		return -ENOMEM;

	efx->nic_data = nic_data;

	nic_data->efx = efx;

	net_dev->features |= efx->type->offload_features;

	net_dev->hw_features |= efx->type->offload_features;

	net_dev->hw_enc_features |= efx->type->offload_features;

	net_dev->vlan_features |= NETIF_F_HW_CSUM | NETIF_F_SG |

				  NETIF_F_HIGHDMA | NETIF_F_ALL_TSO;

	efx->max_vis = EF100_MAX_VIS;



	/* Populate design-parameter defaults */

	nic_data->tso_max_hdr_len = ESE_EF100_DP_GZ_TSO_MAX_HDR_LEN_DEFAULT;

	nic_data->tso_max_frames = ESE_EF100_DP_GZ_TSO_MAX_NUM_FRAMES_DEFAULT;

	nic_data->tso_max_payload_num_segs = ESE_EF100_DP_GZ_TSO_MAX_PAYLOAD_NUM_SEGS_DEFAULT;

	nic_data->tso_max_payload_len = ESE_EF100_DP_GZ_TSO_MAX_PAYLOAD_LEN_DEFAULT;

	netif_set_tso_max_segs(net_dev,

			       ESE_EF100_DP_GZ_TSO_MAX_HDR_NUM_SEGS_DEFAULT);



	/* Read design parameters */

	rc = ef100_check_design_params(efx);

	if (rc) {

		netif_err(efx, probe, efx->net_dev,

			  "Unsupported design parameters\n");

		pci_err(efx->pci_dev, "Unsupported design parameters\n");

		goto fail;

	}
@@ -1012,12 +1004,6 @@ static int ef100_probe_main(struct efx_nic *efx) 
	/* Post-IO section. */



	rc = efx_mcdi_init(efx);

	if (!rc && efx->mcdi->fn_flags &

		   (1 << MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_NO_ACTIVE_PORT)) {

		netif_info(efx, probe, efx->net_dev,

			   "No network port on this PCI function");

		rc = -ENODEV;

	}

	if (rc)

		goto fail;

	/* Reset (most) configuration for this function */
@@ -1033,67 +1019,37 @@ static int ef100_probe_main(struct efx_nic *efx) 
	if (rc)

		goto fail;



	rc = efx_ef100_init_datapath_caps(efx);

	if (rc < 0)

		goto fail;



	efx->max_vis = EF100_MAX_VIS;



	rc = efx_mcdi_port_get_number(efx);

	if (rc < 0)

		goto fail;

	efx->port_num = rc;



	efx_mcdi_print_fwver(efx, fw_version, sizeof(fw_version));

	netif_dbg(efx, drv, efx->net_dev, "Firmware version %s\n", fw_version);

	pci_dbg(efx->pci_dev, "Firmware version %s\n", fw_version);



	if (compare_versions(fw_version, "1.1.0.1000") < 0) {

		netif_info(efx, drv, efx->net_dev, "Firmware uses old event descriptors\n");

		pci_info(efx->pci_dev, "Firmware uses old event descriptors\n");

		rc = -EINVAL;

		goto fail;

	}



	if (efx_has_cap(efx, UNSOL_EV_CREDIT_SUPPORTED)) {

		netif_info(efx, drv, efx->net_dev, "Firmware uses unsolicited-event credits\n");

		pci_info(efx->pci_dev, "Firmware uses unsolicited-event credits\n");

		rc = -EINVAL;

		goto fail;

	}



	rc = ef100_phy_probe(efx);

	if (rc)

		goto fail;



	down_write(&efx->filter_sem);

	rc = ef100_filter_table_probe(efx);

	up_write(&efx->filter_sem);

	if (rc)

		goto fail;



	netdev_rss_key_fill(efx->rss_context.rx_hash_key,

			    sizeof(efx->rss_context.rx_hash_key));



	/* Don't fail init if RSS setup doesn't work. */

	efx_mcdi_push_default_indir_table(efx, efx->n_rx_channels);



	rc = ef100_register_netdev(efx);

	if (rc)

		goto fail;



	return 0;

fail:

	return rc;

}



int ef100_probe_pf(struct efx_nic *efx)

int ef100_probe_netdev_pf(struct efx_nic *efx)

{

	struct ef100_nic_data *nic_data = efx->nic_data;

	struct net_device *net_dev = efx->net_dev;

	struct ef100_nic_data *nic_data;

	int rc = ef100_probe_main(efx);



	if (rc)

		goto fail;

	int rc;



	nic_data = efx->nic_data;

	rc = ef100_get_mac_address(efx, net_dev->perm_addr);

	if (rc)

		goto fail;
@@ -1116,14 +1072,6 @@ void ef100_remove(struct efx_nic *efx) 
{

	struct ef100_nic_data *nic_data = efx->nic_data;



	ef100_unregister_netdev(efx);



	down_write(&efx->filter_sem);

	efx_mcdi_filter_table_remove(efx);

	up_write(&efx->filter_sem);

	efx_fini_channels(efx);

	kfree(efx->phy_data);

	efx->phy_data = NULL;

	efx_mcdi_detach(efx);

	efx_mcdi_fini(efx);

	if (nic_data)
@@ -1142,7 +1090,7 @@ void ef100_remove(struct efx_nic *efx) 
const struct efx_nic_type ef100_pf_nic_type = {

	.revision = EFX_REV_EF100,

	.is_vf = false,

	.probe = ef100_probe_pf,

	.probe = ef100_probe_main,

	.offload_features = EF100_OFFLOAD_FEATURES,

	.mcdi_max_ver = 2,

	.mcdi_request = ef100_mcdi_request,

drivers/net/ethernet/sfc/ef100_nic.h

+9 −1
Original line number Diff line number Diff line
@@ -8,6 +8,8 @@ 
 * under the terms of the GNU General Public License version 2 as published

 * by the Free Software Foundation, incorporated herein by reference.

 */

#ifndef EFX_EF100_NIC_H

#define EFX_EF100_NIC_H



#include "net_driver.h"

#include "nic_common.h"
@@ -15,7 +17,7 @@ 
extern const struct efx_nic_type ef100_pf_nic_type;

extern const struct efx_nic_type ef100_vf_nic_type;



int ef100_probe_pf(struct efx_nic *efx);

int ef100_probe_netdev_pf(struct efx_nic *efx);

int ef100_probe_vf(struct efx_nic *efx);

void ef100_remove(struct efx_nic *efx);
@@ -78,3 +80,9 @@ struct ef100_nic_data { 


#define efx_ef100_has_cap(caps, flag) \

	(!!((caps) & BIT_ULL(MC_CMD_GET_CAPABILITIES_V4_OUT_ ## flag ## _LBN)))



int efx_ef100_init_datapath_caps(struct efx_nic *efx);

int ef100_phy_probe(struct efx_nic *efx);

int ef100_filter_table_probe(struct efx_nic *efx);



#endif	/* EFX_EF100_NIC_H */