Commit 98f481f2 authored by YueHaibing's avatar YueHaibing Committed by Herbert Xu
Browse files

hwrng: core - Use DEVICE_ATTR_<RW|RO> macro 



Use DEVICE_ATTR_RW()/DEVICE_ATTR_RO() helper instead of
plain DEVICE_ATTR, which makes the code a bit shorter and
easier to read.

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent aa22cd7f

drivers/char/hw_random/core.c

+15 −21
Original line number Diff line number Diff line
@@ -319,7 +319,7 @@ static int enable_best_rng(void) 
	return ret;

}



static ssize_t hwrng_attr_current_store(struct device *dev,

static ssize_t rng_current_store(struct device *dev,

				 struct device_attribute *attr,

				 const char *buf, size_t len)

{
@@ -354,7 +354,7 @@ static ssize_t hwrng_attr_current_store(struct device *dev, 
	return err ? : len;

}



static ssize_t hwrng_attr_current_show(struct device *dev,

static ssize_t rng_current_show(struct device *dev,

				struct device_attribute *attr,

				char *buf)

{
@@ -371,7 +371,7 @@ static ssize_t hwrng_attr_current_show(struct device *dev, 
	return ret;

}



static ssize_t hwrng_attr_available_show(struct device *dev,

static ssize_t rng_available_show(struct device *dev,

				  struct device_attribute *attr,

				  char *buf)

{
@@ -392,22 +392,16 @@ static ssize_t hwrng_attr_available_show(struct device *dev, 
	return strlen(buf);

}



static ssize_t hwrng_attr_selected_show(struct device *dev,

static ssize_t rng_selected_show(struct device *dev,

				 struct device_attribute *attr,

				 char *buf)

{

	return sysfs_emit(buf, "%d\n", cur_rng_set_by_user);

}



static DEVICE_ATTR(rng_current, S_IRUGO | S_IWUSR,

		   hwrng_attr_current_show,

		   hwrng_attr_current_store);

static DEVICE_ATTR(rng_available, S_IRUGO,

		   hwrng_attr_available_show,

		   NULL);

static DEVICE_ATTR(rng_selected, S_IRUGO,

		   hwrng_attr_selected_show,

		   NULL);

static DEVICE_ATTR_RW(rng_current);

static DEVICE_ATTR_RO(rng_available);

static DEVICE_ATTR_RO(rng_selected);



static struct attribute *rng_dev_attrs[] = {

	&dev_attr_rng_current.attr,